Skip to content

Add #EuroPython #Python hashtags to bingo share#1699

Merged
hugovk merged 7 commits into
ep2026from
share-bingo
Jul 4, 2026
Merged

Add #EuroPython #Python hashtags to bingo share#1699
hugovk merged 7 commits into
ep2026from
share-bingo

Conversation

@hugovk

@hugovk hugovk commented Jun 29, 2026

Copy link
Copy Markdown
Member

Also list social networks in same order as homepage:

image

@europython-society

europython-society commented Jun 29, 2026

Copy link
Copy Markdown
Member

Preview available

Key Value
url https://share-bingo.ep-preview.click
last update 2026-07-03T23:50:55.949Z

}

const BINGO_PAGE_URL = 'https://ep2026.europython.eu/#bingo';
const BINGO_PAGE_URL = 'https://ep2026.europython.eu/bingo';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was suggested to me before, but other sections have URLS like https://ep2026.europython.eu/#krakow - don't we want to be consistent? And does the hash even matter?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need them, they look a bit weird, and when I click around the site, I don't see any hashes like this in URLs (not counting mid-page anchors)

Comment thread src/components/island/BingoCard.svelte Outdated
@dariagrudzien

Copy link
Copy Markdown
Contributor

@hugovk I don't really know why, but this change breaks LinkedIn sharing by removing the URL, by clipping everything after the last question including the URL:

this PR
image

prod
image

@dariagrudzien dariagrudzien self-requested a review June 29, 2026 23:24
Co-authored-by: Daria Grudzien <hello@dariagrudzien.com>
@hugovk

hugovk commented Jul 3, 2026

Copy link
Copy Markdown
Member Author

I don't really know why, but this change breaks LinkedIn sharing by removing the URL, by clipping everything after the last question including the URL:

Hmm, this is what Claude suggests:

Root cause: The ? introduced in commit c191e31 ("What about you:" → "What about you?").
The text is sent correctly encoded as %3F, but LinkedIn's shareActive flow decodes the
text parameter and re-parses it internally, so a literal ? in the decoded text truncates
everything after it. The # characters are not the issue — prod's URL contained /#bingo
and shared intact, so the new hashtags can stay.

The fix in src/components/island/BingoCard.svelte:51: buildShareText() now takes a
forLinkedIn flag. LinkedIn gets the ?-free "What about you:" phrasing, while X, Bluesky,
and Mastodon keep "What about you?". A comment notes the LinkedIn quirk so nobody
reintroduces it.

Worth verifying with a real LinkedIn account before merging, since this behavior is
entirely on LinkedIn's side and undocumented — the diagnosis rests on the prod-vs-PR
comparison in Daria's screenshots. If you'd rather not have per-network phrasing, the
alternative is reverting to "What about you:" everywhere.

diff --git a/src/components/island/BingoCard.svelte b/src/components/island/BingoCard.svelte
index 085796e6..1688e91c 100644
--- a/src/components/island/BingoCard.svelte
+++ b/src/components/island/BingoCard.svelte
@@ -48,18 +48,20 @@
     } catch {}
   }
 
-  function buildShareText() {
+  function buildShareText(forLinkedIn = false) {
     const attended = editions.filter((_, i) => checked[i]).map(e => `${e.year} ${e.city}`);
     const count = attended.length;
     const base = `I've attended ${count} EuroPython conference${count !== 1 ? 's' : ''}! 🐍`;
     const body = count > 0 ? `${base}\n\n${attended.join(' · ')}` : base;
-    return `${body}\n\nWhat about you? ${BINGO_PAGE_URL}\n\n#EuroPython #Python`;
+    // LinkedIn drops everything after a "?" in the prefilled text, even when encoded
+    const prompt = forLinkedIn ? 'What about you:' : 'What about you?';
+    return `${body}\n\n${prompt} ${BINGO_PAGE_URL}\n\n#EuroPython #Python`;
   }
 
   const BINGO_PAGE_URL = 'https://ep2026.europython.eu/bingo';
 
   function shareLinkedIn() {
-    const text = buildShareText();
+    const text = buildShareText(true);
     window.open(
       `https://www.linkedin.com/feed/?shareActive=true&text=${encodeURIComponent(text)}`,
       '_blank', 'noopener,noreferrer'

But we can just change "What about you?" back to "What about you:" for a quick fix.

@dariagrudzien

Copy link
Copy Markdown
Contributor

But we can just change "What about you?" back to "What about you:" for a quick fix.

Sure, that makes sense. Let's make sure to keep 2 newlines before the hashtags, so the url pops out.

I'm heading for the EP and some family time before that, will be mostly offline from now on.

Comment thread src/components/island/BingoCard.svelte Outdated
@hugovk

hugovk commented Jul 3, 2026

Copy link
Copy Markdown
Member Author

But we can just change "What about you?" back to "What about you:" for a quick fix.

Sure, that makes sense. Let's make sure to keep 2 newlines before the hashtags, so the url pops out.

Done, back to colon, and with 2 newlines before the hashtags.

I'm heading for the EP and some family time before that, will be mostly offline from now on.

Have a good break before EP!

Perhaps someone else can approve/merge.

@hypha hypha left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on LinkedIn and looks good now.

@nikoshell

Copy link
Copy Markdown
Contributor

@hugovk I don't really know why, but this change breaks LinkedIn sharing by removing the URL, by clipping everything after the last question including the URL:

this PR image

prod image

We should check our main page OpenGraph details to be sure that there is no issue when we share it on socials.

@nikoshell

nikoshell commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Not related to this PR.
#1732

@hugovk hugovk dismissed dariagrudzien’s stale review July 4, 2026 07:05

Dismissing to see if this let's me merge...

@hugovk hugovk merged commit 4c7bba2 into ep2026 Jul 4, 2026
9 checks passed
@hugovk hugovk deleted the share-bingo branch July 4, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants